March 2, 2016

Week in Core, Feb. 23-Mar 1 2016

Welcome back the latest issue of Week in Core, covering changes [36672-36800]. Here are the highlights:

  • 128 commits
  • 52 contributors
  • 115 tickets created
  • 19 tickets reopened
  • 135 tickets closed

Ticket numbers based on trac timeline for the period above.

Note: If you want to help write the next WordPress Core Weekly summary, check out the schedule over at make/docs and get in touch in the #core-weekly-update Slack channel.

Code Changes

Accessibility

  • improve accessibility of the Dashboard “Recent Comments” widget. [36683] #35392

Comments

Customize

  • Use selective refresh to preview changes to site title and tagline in core themes. Fixes #33738. [36797] #27355, #33738
  • Fix PHP notice when calling WP_Customize_Control::json() inside content_template() method. See #29572. [36776] #35926, #29572
  • Allow button_labels to be overridden in $args passed to WP_Customize_Media_Control and WP_Customize_Image_Control. [36769] #33755, #35542
  • Introduce Logo support for themes. See #33755. [36698] #33755
  • Allow controls to be registered without any associated settings. Fixes #35926. [36689] #27355, #35926
  • Introduce customize_nav_menu_searched_items filter for modifying results of nav menu item searches. [36676] #34947
  • Fix nav menu item search after Backbone update. [36675] #34350

Docs

  • Correct filter reference in pre_get_avatar filter description. [36800] #36031
  • Correct _n_noop() and _nx_noop() descriptions to use third-person singular verbs. [36765] #35961
  • Improve a variety of DocBlocks in wp-includes/deprecated.php. [36763] #32246
  • Add missing parameter and return descriptions to the DocBlock for the deprecated default_topic_count_text(). [36760] #32246
  • Add missing parameter and return documentation to the DocBlock for the deprecated _search_terms_tidy(). [36759] #32246
  • Add missing documentation for the &$post parameter in the DocBlock for the deprecated _get_post_ancestors(). [36758] #32246
  • Add missing documentation for the $fp parameter to the DocBlock for the deprecated debug_fclose(). [36757] #32246
  • Add missing parameter documentation to the DocBlock for the deprecated debug_fwrite(). [36756] #32246
  • Add missing parameter and return documentation to the DocBlock for the deprecated debug_fopen(). [36755] #32246
  • Add missing documentation for the $wp_admin_bar parameter in the DocBlock for the deprecated wp_admin_bar_dashboard_view_site_menu(). [36754] #32246
  • Add missing documentation for the $title parameter in the DocBlock for the deprecated parent_post_rel_link(). [36753] #32246
  • Remove a duplicate parameter notation in the DocBlock for the deprecated the_editor() function. [36748] #32246
  • Update the @deprecated tag comment for wp-includes/embed-template.php to reference the correct file path following [36693]. [36746] #34561
  • Add a missing summary, @access tag, and parameter documentation to the DocBlock for WP_Customize_Filter_Setting::update(). [36745] #32246
  • Improve inline docs for WP_Dependencies, WP_Styles, and WP_Scripts. [36744] #35964
  • Fix two typos in return descriptions for WP_Theme private usort() methods. [36739] #32246
  • Add missing parameter and return notations in the DocBlock for WP_Theme::_name_sort_i18n(). [36738] #32246
  • Add missing parameter and return notations in the DocBlock for WP_Theme::_name_sort(). [36737] #32246
  • Add a missing description for the &$themes parameter in the DocBlock for WP_Theme::sort_by_name(). [36736] #32246
  • Correctly document parameters in the hook doc for the get_meta_sql filter as individual parameters rather than an array. [36735] #35962
  • Add missing parameter and return descriptions to the DocBlock for WP_Theme::__isset(). [36734] #32246
  • Add missing @since tags to WP_Styles properties/methods. [36733] #35964
  • In WP_Dependencies add a changelog entry for the $group parameter. [36732] #35964
  • In WP_Dependencies add a changelog entry to methods which were moved from WP_Scripts to WP_Dependencies. [36731] #35964
  • Document properties of WP_Scripts and add missing @since tags. [36730] #35964
  • Use correct @since tags for script enqueue functions. See #35964. [36729] #35964
  • Add missing @param and @return notations to the DocBlock for WP_Feed_Cache_Transient::save(). [36728] #32246
  • Use the correct variable name for the $post_ID parameter in the DocBlock for wp_add_trashed_suffix_to_post_name_for_trashed_posts(). [36727] #11863, #32246
  • Standardize summaries for two new internal functions used to handle suffixing trashed posts […] and a notation of private access to each. [36726] #11863, #32246
  • Add some missing @param notations to various DocBlocks in wp-includes/ms-deprecated.php. [36725] #32246
  • Add a missing @param entry for the $user_login parameter in the DocBlock for the deprecated is_site_admin() function. [36724] #32246
  • Add a missing @param entry for the $len parameter in the DocBlock for the deprecated generate_random_password() function. [36723] #32246
  • Correct the possible return types for WP_Dependencies::query(). [36713] #32246
  • Improve the description of the get_object_taxonomies() function. Uncertainty has no place in documentation. [36712] #32246
  • Use a third-person singular verb in the DocBlock summary for wp_add_inline_script(), introduced in [36633]. [36707] #14853, #32246
  • Standardize DocBlocks for two new WP_Scripts methods, add_inline_script() and print_inline_script(), introduced in [36633]. [36706] #14853, #32246
  • Make a few syntactical improvements to the DocBlock for _wp_get_current_user(), introduced in [36651]. [36705] #19615, #32246
  • Add an inline @see tag to link up the plugins_loaded hook in the description for the customize_loaded_components filter. [36687] #32246

Editor

  • Remove an unused JavaScript variable so the JS lint tests pass. [36751] #33301

Embeds

  • Use a more accessible way to initially hide the iframe. This [36708] #35894
  • Update embed template paths and messages in tests, missed in [36693]. [36694] #34561
  • Introduce embed templates into the template hierarchy via theme-compat. [36693] #34561

External Libraries

Formatting

  • In sanitize_title_with_dashes(), convert `,&ndash, and&mdash` HTML entities to hyphens on save. [36775] #31790

Forms

  • Swap “Submit” button label for “Enter” on password-protected pages. [36685] #35042

HTTP API

  • Add the missing 1xx HTTP response codes as constants of the WP_Http class, and add tests to ensure all available response codes are covered. [36749] #36294

I18N

  • Move the aria-label text in comment_form() to a separate string for easier translation. Add translator comments. [36794] #36014
  • Remove HTML tags from translatable string in wp-admin/includes/dashboard.php. [36793] #36013
  • Remove ` tags from translatable string in wp-admin/network/site-new.php`. [36773] #35994
  • Remove ` tag from translatable string in wp-includes/class-wp-customize-manager.php`. [36772] #35992
  • Remove ` tag from translatable string in wp-admin/network/site-new.php`. [36771] #35989
  • Remove HTML tags from translatable strings in wp-admin/network/themes.php. [36770] #35988
  • Fix placeholders and add translator comments after [36695]. [36697] #35705
  • Move the “Caution:” prefix to a separate string in wp-admin/includes/network.php. [36690] #35674

I18N Tools

L10n

Link Manager

  • Fix usage of translation functions after [35998].

Mail

Media

  • JSHint for wp-playlist.js. File was added to the watchlist in [36780]. [36783] #35984
  • Add support for minified versions of wp-playlist.js, wp-mediaelement.js and wp-mediaelement.css. [36780] #35984
  • Correct “Exception” typo in WP_Image_Editor_Imagick::strip_meta(). Exceptions are caught better if they’re not excpeted. [36742] #33642
  • Optimize Imagick settings for quality and filesize. [36700] #33642, #30402, #28634
  • Fix broken delete/trash functionality in the library after [36546]. [36681] #34350

Multisite

  • Provide an “Edit user” link after adding a new user [36695] #35705
  • Use “Site Address (URL)” in site-new.php. [36684] #35934
  • Show the main site’s domain and path in site-info.php [36682] #35632
  • Switch to a usermeta key for email confirmation. [36679] #23358

Posts

  • Add tests for the cascading fallback behavior of several ‘public’-related arguments in register_post_type(). [36768] #35985
  • Rename the $args parameter in get_post_types_by_support() to $feature for better self-documentation. [36704] #34010, #32246

REST API

Rewrite Rules

  • Ensure url_to_postid() operates as expected when it’s used in the context of another site within a Multisite network that uses mixed URL schemes. [36750] #35531

Spelling

  • Standardize on “front end”/”back end” (noun) and “front-end”/”back-end” (adjective). [36709] #34887

Taxonomy

  • Improve ‘offset’ calculation when querying for hierarchical terms. [36691] #8832, #35935

Tests

  • Add unit tests for number_format_i18n(). [36795] #36029
  • Use markTestSkipped() to skip a multisite-only test. [36791] #36016
  • Ensure that user __unset() tests make assertions. [36790] #36016
  • Remove erroneous return in date_query test. Introduced in [34989]. [36789] #36016
  • mbstring.func_overload test should be skipped properly. This avoids PHPUnit notices related to “risky” tests. [36788] #36016
  • Remove tests related to wp_*_post_meta() functions. [36787] #21767, #36016
  • Make sure that test_wp_mail_break_it() makes an assertion. Let’s make what is possibly the oddest test in WordPress even a bit odder. See #36016. [36786] #36016
  • setExpectedDeprecated and setExpectedIncorrectUsage tests should make assertions. Introduced in [31306]. [36785] #36016
  • More specific test for a bad callback in WP_Customize_Partial test. [36784] #27355, #36016
  • Remove test related to deprecated Customizer export_preview_data() method. The method was gutted and deprecated in [36586], so there’s no reason to keep the test. [36782] #36016
  • Put an assertion in test_nonexistent_array() test. [36779] #36016
  • Make sure an assertion takes place in ‘visited’ test for get_category_parents(). [36778] #36016
  • Ad a unit test for bool_from_yn(). [36764] #35972
  • Don’t modify global state before checking whether to skip get_locale() tests. Introduced in [36740]. [36741] #35965
  • Add tests for get_locale(). [36740] #35965
  • Remove (or at least reduce) the need to reset common $_SERVER variables before assertions or between tests, by introducing a method which automatically resets them during test setup. [36721] #35954
  • Correct some more tests which were using example.org instead of WP_TESTS_DOMAIN. [36717] #34000
  • Move some assertions in HTTPS related tests, so failures that occur before the environment reset don’t result in a contaminated test environment. [36711] #35954
  • Unify the initialisation of $_SERVER variables during test bootstrap. This abstracts the (re-)initialisation into a function that can be used inside of tests too, before assertions are performed. [36715] #35954

TinyMCE

TinyMCE inline link dialog

  • Fix running wpLink without tinymce.js and the TinyMCE plugin without wplink.js. Do not show the Advanced button in the inline link dialog when wpLink is not loaded. [36777] #33301
  • Fix in IE (again). Remove setting/getting placeholders, pass the link node instead. In the inline dialog: when the selected text looks like URL or email, pre-fill the URL field with it (same as in the modal). Fix setting the name of the main button in the modal: Add Link or Update. In the modal when clicking Update remove the link if the URL field is empty. That matches the inline dialog behaviour. Otherwise the modal remains open, nothing happens when clicking the Update button there. [36747] #33301
  • Fix applying the changes when pressing the Enter key in Firefox. [36743] #33301
  • Make sure the inline dialog is not showing under the advanced modal. Fix checking if the link node contains text. Fix undo levels so all actions can be undone and redone. [36716] #33301
  • Reset the inline dialog when canceling the advanced modal. If there is a link it should be on the first stage: follow/preview link. Fix tabbing in the inline edit dialog. [36703] #33301
  • Remove the bottom half of the (old) modal and add autocomplete on the URL field. Disable the inline edit dialog in old IE (7, 8 and 9). Use only the modal there. Fix in IE10 and 11. Fix (most?) remaining edge cases. Fix focusing the inline dialog, the modal and the editor. [36677] #33301

TinyMCE textpattern

  • Horizontal line is translated, Horizontal rule is not. [36762] #33300
  • Add description of the new patterns to the Shortcuts help modal. Fix the layout a bit and make the patterns in two columns. Disable the textpatterns plugin in IE < 9. [36761] #33300
  • fix error when inserting “ if the new paragraph is not direct child of the body. [36720] #33300
  • Use editor.once instead of storing into variables. Add pattern for hr. [36719] #33300

Upgrade

  • Bump db version for upgrade_450() in upgrade_all(). [36686] #23358

Props

Thanks to @adamsilverstein, @afercia, @Ankit, @azaozz, @bhubbard, @boonebgorges, @borgesbruno, @celloexpressions, @chetanchauhan, @codex-m, @danielbachhuber, @dnewton, @DrewAPicture, @eliorivero, @enejb, @flixos90, @Gupta, @henrywright, @imath, @iseulde, @jeherve, @jeremyfelt, @joemcgill, @johnbillion, @jorbin, @K, @karmatosed, @kovshenin, @kwight, @maweder, @melchoyce, @MikeHansenMe, @mikeschroder, @obenland, @obrienlabs, @ocean90, @pbearne, @pento, @polevaultweb, @rachelbaker, @ramiy, @realloc, @rmccue, @ryan, @samhotchkiss, @SergeyBiryukov, @sudar, @swissspidy, @thewanderingbrit, @TimothyBlynJacobs, @westonruter, and @zinigor for their contributions!



Week in Core, Feb. 23-Mar 1 2016 by Grant Palin was originally posted at https://make.wordpress.org/core/2016/03/02/week-in-core-feb-23-mar-1-2016/
Posted by
Labels:

No comments:

Post a Comment

Subscribe to: Post Comments (Atom)